Biasqo commented on PR #171: URL: https://github.com/apache/flink-connector-jdbc/pull/171#issuecomment-2972732867
> Thanks for your contribution, I can't start CI/CD sorry. @1996fanrui can you start it? > > > > I review the main code and left minor comments. > > I dont review the tests as you have a TODO to some refactoring there. > > > > You also need to add this module on flink-connector-jdbc-architecture. Is it okay if I refactor some of the core classes in the tests, like making them protected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
