eskabetxe commented on PR #171: URL: https://github.com/apache/flink-connector-jdbc/pull/171#issuecomment-2987465006
> @eskabetxe Thanks for getting back to me > > 1. I’m using version 0.6.2 since 0.8+ has some dependency issues with httpcore, and I didn’t want to change the existing httpcore version. If it’s okay to upgrade some of the libraries already included in the distribution, I can go ahead and fix it. > 2. I will revert .vcs > 3. About the tests: I’m not sure if I can override some private methods that are part of abstract test classes (for example, the abstract class TableBase, method getStreamFields). If I’m allowed to make them protected, the number of test classes could be significantly reduced. Clickhouse has its unique create statement - that's why it was a problem Its ok to bump some versions and is ok also change some test methods from private to protected if you need to override them.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
