lvyanquan commented on code in PR #4066:
URL: https://github.com/apache/flink-cdc/pull/4066#discussion_r2259194751
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/SchemaChangeProvider.java:
##########
@@ -158,7 +158,7 @@ public static List<SchemaChange> drop(String columnName) {
public static String defaultValueOptionKey(String columnName) {
return String.format(
"%s.%s.%s",
- CoreOptions.FIELDS_PREFIX, columnName,
CoreOptions.DEFAULT_VALUE_SUFFIX);
+ CoreOptions.FIELDS_PREFIX, columnName,
SchemaChangeProvider.DEFAULT_VALUE_SUFFIX);
Review Comment:
This can be removed.
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/SchemaChangeProvider.java:
##########
@@ -65,7 +65,7 @@ public static List<SchemaChange>
add(AddColumnEvent.ColumnWithPosition columnWit
"%s.%s.%s",
CoreOptions.FIELDS_PREFIX,
column.getName(),
- CoreOptions.DEFAULT_VALUE_SUFFIX);
+
SchemaChangeProvider.DEFAULT_VALUE_SUFFIX);
result.add(SchemaChangeProvider.setOption(key,
value));
Review Comment:
We should update the way of setting default value using newly added API.
```
Optional.ofNullable(column.getDefaultValueExpression())
.ifPresent(
value -> {
result.add(
SchemaChange.updateColumnDefaultValue(new String[]{column.getName()},
column.getDefaultValueExpression()));
});
```
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/SchemaChangeProvider.java:
##########
@@ -36,7 +36,7 @@
* represent different types of schema modifications.
*/
public class SchemaChangeProvider {
-
+ private static final String DEFAULT_VALUE_SUFFIX = "default-value";
Review Comment:
This variable should be removed.
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/SchemaChangeProvider.java:
##########
@@ -103,7 +103,7 @@ public static List<SchemaChange> add(
"%s.%s.%s",
CoreOptions.FIELDS_PREFIX,
column.getName(),
- CoreOptions.DEFAULT_VALUE_SUFFIX);
+
SchemaChangeProvider.DEFAULT_VALUE_SUFFIX);
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
