junmuz commented on code in PR #4066:
URL: https://github.com/apache/flink-cdc/pull/4066#discussion_r2259486554
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/SchemaChangeProvider.java:
##########
@@ -65,7 +65,7 @@ public static List<SchemaChange>
add(AddColumnEvent.ColumnWithPosition columnWit
"%s.%s.%s",
CoreOptions.FIELDS_PREFIX,
column.getName(),
- CoreOptions.DEFAULT_VALUE_SUFFIX);
+
SchemaChangeProvider.DEFAULT_VALUE_SUFFIX);
result.add(SchemaChangeProvider.setOption(key,
value));
Review Comment:
Yes that's correct. I considered that but this will requires [paimon-api
dependency
addition](https://github.com/apache/paimon/blob/release-1.2.0/paimon-api/src/main/java/org/apache/paimon/schema/SchemaChange.java#L159-L161)
as a dependency. Initially I was looking for a simpler change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
