Au-Miner commented on code in PR #26907:
URL: https://github.com/apache/flink/pull/26907#discussion_r2278357982
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/rules/physical/stream/DuplicateChangesInferRuleTest.java:
##########
@@ -284,23 +292,15 @@ void testExpandAndIncrementalAggregate() {
.set(OptimizerConfigOptions.TABLE_OPTIMIZER_DISTINCT_AGG_SPLIT_ENABLED, true);
String sql =
- "insert into pk_snk select a, max(b), count(distinct c) from
append_src1 group by a";
+ "insert into pk_upsert_snk select a, max(b), count(distinct c)
from append_src1 group by a";
verifyRelPlanInsert(sql);
}
@TestTemplate
void testDropUpdateBefore() {
assumeTrue(testSinkWithPk);
- util.tableEnv()
- .executeSql(
- "CREATE TABLE upsert_snk WITH (\n"
- + " 'sink-changelog-mode-enforced' = 'I,UA,D'"
- + ") LIKE pk_snk (\n"
- + " OVERWRITING OPTIONS\n"
- + ")");
-
- String sql = "insert into pk_snk select a,b,c from retract_src";
+ String sql = "insert into pk_upsert_snk select a,b,c from retract_src";
Review Comment:
Some places are a,b,c, while others are a, b, c. The code style for spaces
can be unified.
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/rules/physical/stream/DuplicateChangesInferRuleTest.java:
##########
@@ -284,23 +292,15 @@ void testExpandAndIncrementalAggregate() {
.set(OptimizerConfigOptions.TABLE_OPTIMIZER_DISTINCT_AGG_SPLIT_ENABLED, true);
String sql =
- "insert into pk_snk select a, max(b), count(distinct c) from
append_src1 group by a";
+ "insert into pk_upsert_snk select a, max(b), count(distinct c)
from append_src1 group by a";
verifyRelPlanInsert(sql);
}
@TestTemplate
void testDropUpdateBefore() {
assumeTrue(testSinkWithPk);
- util.tableEnv()
- .executeSql(
- "CREATE TABLE upsert_snk WITH (\n"
- + " 'sink-changelog-mode-enforced' = 'I,UA,D'"
- + ") LIKE pk_snk (\n"
- + " OVERWRITING OPTIONS\n"
- + ")");
-
- String sql = "insert into pk_snk select a,b,c from retract_src";
+ String sql = "insert into pk_upsert_snk select a,b,c from retract_src";
Review Comment:
Some places are a,b,c, while others are a, b, c. The code style for spaces
can be unified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
