gyfora commented on code in PR #1018:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1018#discussion_r2293494223
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/IngressUtils.java:
##########
@@ -74,7 +74,9 @@ public static void reconcileIngress(
FlinkDeploymentSpec spec,
Configuration effectiveConfig,
KubernetesClient client) {
-
+ if (!ctx.getOperatorConfig().isManageIngress()) {
+ return;
Review Comment:
may be better to throw a reconciliation error if the user actually needs an
ingress and it is turned off. Or at least log a warning and trigger an event.
Maybe the exception is too drastic but the event is a minimum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
