csviri commented on code in PR #1018:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1018#discussion_r2297428697
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/IngressUtils.java:
##########
@@ -68,13 +70,30 @@ public class IngressUtils {
private static final String REST_SVC_NAME_SUFFIX = "-rest";
private static final Logger LOG =
LoggerFactory.getLogger(IngressUtils.class);
+ public static final String INGRESS_MANAGEMENT_OFF_BUT_SPEC_SET =
+ "Ingress management is turned off but ingress set in spec";
+ public static final String INGRESS_MANAGEMENT = "IngressManagement";
public static void reconcileIngress(
FlinkResourceContext<?> ctx,
FlinkDeploymentSpec spec,
Configuration effectiveConfig,
- KubernetesClient client) {
+ KubernetesClient client,
+ EventRecorder eventRecorder) {
+ if (!ctx.getOperatorConfig().isManageIngress()) {
+ if (spec.getIngress() != null) {
+ log.warn(INGRESS_MANAGEMENT_OFF_BUT_SPEC_SET);
Review Comment:
removed log, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
