lihaosky commented on code in PR #26924:
URL: https://github.com/apache/flink/pull/26924#discussion_r2310485523


##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/SystemTypeInference.java:
##########
@@ -147,7 +159,9 @@ private static void 
checkScalarArgsOnly(List<StaticArgument> defaultArgs) {
         checkPassThroughColumns(declaredArgs);
 
         final List<StaticArgument> newStaticArgs = new 
ArrayList<>(declaredArgs);
-        newStaticArgs.addAll(PROCESS_TABLE_FUNCTION_SYSTEM_ARGS);

Review Comment:
   This is to control whether `uid`, `ontime` field will be added to ptf input. 
This is currently used by `ml_predict` because it doesn't need `uid` and 
`ontime` field. It's not exposed to PTF function user can define. Yes. I can 
add more description if this approach makes sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to