lihaosky commented on code in PR #26924:
URL: https://github.com/apache/flink/pull/26924#discussion_r2370320280
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalProcessTableFunctionRule.java:
##########
@@ -69,13 +71,17 @@ public boolean matches(RelOptRuleCall call) {
}
final RexCall rexCall = (RexCall) scan.getCall();
final FunctionDefinition definition =
ShortcutUtils.unwrapFunctionDefinition(rexCall);
- return definition != null && definition.getKind() ==
FunctionKind.PROCESS_TABLE;
+ return definition != null
+ &&
!StreamPhysicalMLPredictTableFunctionRule.isMLPredictFunction(definition)
+ && definition.getKind() == FunctionKind.PROCESS_TABLE;
}
@Override
public @Nullable RelNode convert(RelNode rel) {
final FlinkLogicalTableFunctionScan scan =
(FlinkLogicalTableFunctionScan) rel;
final RexCall rexCall = (RexCall) scan.getCall();
+ validateAllowSystemArgs(rexCall);
Review Comment:
I'll drop the validation here and keep the validation in
`StreamPhysicalProcessTableFunction` constructor. The constructor was also
called in `StreamPhysicalConstantTableFunctionScanRule`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
