davidradl commented on code in PR #26954:
URL: https://github.com/apache/flink/pull/26954#discussion_r2313616729
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonParserToRowDataConverters.java:
##########
@@ -266,7 +266,7 @@ private int convertToTime(JsonParser jsonNode) throws
IOException {
LocalTime localTime = parsedTime.query(TemporalQueries.localTime());
// get number of milliseconds of the day
- return localTime.toSecondOfDay() * 1000;
+ return (int) (localTime.toNanoOfDay() / 1000_000);
Review Comment:
If we change the way that the json format parses times, then the output will
change for existing users, which has implications to the logic of their
processing. I suggest that this way of parsing be enabled by a new json format
configuration option - so it can be knowingly adopted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
