raminqaf commented on code in PR #26954:
URL: https://github.com/apache/flink/pull/26954#discussion_r2316303536
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java:
##########
@@ -795,7 +856,9 @@ private static List<TestSetSpec> allTypesBasic() {
// https://issues.apache.org/jira/browse/FLINK-24423
Continue using EPOCH
// date or use 0 for the year?
.fromCase(
- TIME(5), DEFAULT_TIME, LocalDateTime.of(1970,
1, 1, 12, 34, 56, 0))
+ TIME(5),
+ DEFAULT_TIME,
+ LocalDateTime.of(1970, 1, 1, 12, 34, 56,
123_000_000))
Review Comment:
We are not really supporting TIME(5). As far as I understood, the time
converters are storing the time as integer and not as long. We lose the
precession (>3) there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
