Efrat19 commented on code in PR #26985:
URL: https://github.com/apache/flink/pull/26985#discussion_r2347297700
##########
flink-metrics/flink-metrics-otel/src/main/java/org/apache/flink/traces/otel/OpenTelemetryTraceReporter.java:
##########
@@ -124,10 +124,9 @@ private void notifyOfAddedSpanInternal(Span span,
io.opentelemetry.api.trace.Spa
.startSpan();
// Recursively add child spans to this parent
- // TODO: not yet supported
- // for (Span childSpan : span.getChildren()) {
- // notifyOfAddedSpanInternal(childSpan, currentOtelSpan);
- // }
Review Comment:
Nit: remove comment? (code is identical to the loop below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
