davidradl commented on code in PR #26985:
URL: https://github.com/apache/flink/pull/26985#discussion_r2348353921
##########
flink-core/src/main/java/org/apache/flink/configuration/TraceOptions.java:
##########
@@ -67,6 +82,19 @@ public static Configuration forReporter(Configuration
configuration, String repo
+ " any of the names in the list will be
started. Otherwise, all reporters that could be found in"
+ " the configuration will be started.");
+ /** The detail level for reporting checkpoint spans. */
+ public static final ConfigOption<TraceOptions.CheckpointSpanDetailLevel>
+ CHECKPOINT_SPAN_DETAIL_LEVEL =
+ key("traces.checkpoint.span-detail-level")
+
.enumType(TraceOptions.CheckpointSpanDetailLevel.class)
+
.defaultValue(CheckpointSpanDetailLevel.SPANS_PER_CHECKPOINT)
+ .withDescription(
+ "Detail level for reporting checkpoint
spans. Possible values:\n"
+ + "- SPAN_PER_CHECKPOINT
(default): Single span per checkpoint. Aggregated sum/max for submetrics from
all tasks and subtasks per checkpoint\n"
Review Comment:
@Efrat19 in the case of SPAN_PER_CHECKPOINT there is only one span so
singular makes sense top me. The others could have multiple so are SPANS.
SPANS_PER_TASK will have a SPAN for each task plus one for the PARENT, so is
a bit misleading. We could say
CHILDEN_SPANS_PER_TASK and CHILDEN_SPANS_PER_SUBTASK if we think this is
clearer. WDYT @pnowojski ? I do not have strong views to change this, but
thought I would bring it to your attention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
