letaoj commented on code in PR #138:
URL: https://github.com/apache/flink-agents/pull/138#discussion_r2347598649
##########
runtime/src/main/java/org/apache/flink/agents/runtime/memory/MemoryObjectImpl.java:
##########
@@ -35,6 +36,7 @@ private enum ItemType {
private static final String SEPARATOR = ".";
private final MapState<String, MemoryItem> store;
+ private final List<MemoryUpdate> memoryUpdates;
Review Comment:
sounds good. The reason why I keep it inside of the memory object is because
it will ease how we keep track of the memory updates. We can tracks the update
when the put is called but if the update is inside of the context, i might need
to figure out a way to find the updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
