letaoj commented on code in PR #138:
URL: https://github.com/apache/flink-agents/pull/138#discussion_r2347600606
##########
runtime/src/main/java/org/apache/flink/agents/runtime/operator/ActionExecutionOperator.java:
##########
@@ -301,20 +309,47 @@ private void processActionTaskForKey(Object key) throws
Exception {
// 2. Invoke the action task.
createAndSetRunnerContext(actionTask);
- ActionTask.ActionTaskResult actionTaskResult = actionTask.invoke();
- for (Event actionOutputEvent : actionTaskResult.getOutputEvents()) {
+
+ boolean isFinished = false;
+ List<Event> outputEvents;
+ Optional<ActionTask> generatedActionTaskOpt;
+ ActionState actionState = actionStateStore.get(key, actionTask.action);
Review Comment:
Originally, I was thinking that for the same action, we should always
produce the same result but think about it twice, even the same action with
different memory, the result could be different. I will update the key to
include event id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
