RocMarshal commented on code in PR #26976:
URL: https://github.com/apache/flink/pull/26976#discussion_r2347717542
##########
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java:
##########
@@ -197,15 +197,7 @@ public HistoryServer(
webRefreshIntervalMillis =
config.get(HistoryServerOptions.HISTORY_SERVER_WEB_REFRESH_INTERVAL).toMillis();
- String webDirectory =
config.get(HistoryServerOptions.HISTORY_SERVER_WEB_DIR);
- if (webDirectory == null) {
- webDirectory =
- System.getProperty("java.io.tmpdir")
- + File.separator
- + "flink-web-history-"
- + UUID.randomUUID();
- }
- webDir = new File(webDirectory);
+ webDir = prepareWebDir(config);
Review Comment:
Of course, I have added a unit test for this change.
Thank you for your comments. Could you @davidradl help take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
