davidradl commented on code in PR #26976:
URL: https://github.com/apache/flink/pull/26976#discussion_r2378173611
##########
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java:
##########
@@ -257,6 +249,35 @@ public HistoryServer(
HistoryServer.this::stop,
HistoryServer.class.getSimpleName(), LOG);
}
+ private File prepareWebDir(Configuration config) throws IOException {
+ final File webDir;
+ String webDirectory =
config.get(HistoryServerOptions.HISTORY_SERVER_WEB_DIR);
+ if (webDirectory == null) {
+ webDirectory =
+ System.getProperty("java.io.tmpdir")
+ + File.separator
+ + "flink-web-history-"
+ + UUID.randomUUID();
+ }
+ webDir = new File(webDirectory);
+ LOG.info("Reset the web directory {}", webDir);
Review Comment:
nit: I suggest saying `Clear `or 'empty' rather than `Reset` - also the
method name would be more self explanatory if it was` clearWebDir ` I, think.
But it is up to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
