letaoj commented on code in PR #138:
URL: https://github.com/apache/flink-agents/pull/138#discussion_r2350211840


##########
api/src/main/java/org/apache/flink/agents/api/context/RunnerContext.java:
##########
@@ -73,4 +75,12 @@ public interface RunnerContext {
      * @return the configuration for Flink Agents.
      */
     ReadableConfiguration getConfig();
+
+    /**
+     * Gets all the updates made to this MemoryObject since it was created or 
the last time this
+     * method was called.
+     *
+     * @return list of memory updates
+     */
+    List<MemoryUpdate> getAllMemoryUpdates();

Review Comment:
   I will move it to the RunnerContextImpl since I do see some method that 
lives in the RunnerContextImpl and seems to be internal. ActionTask's 
`getRunnerContext` method is also returning the `RunnerContextImpl` because I 
think it has some internal only method that needs to be accessed by the 
operator. If you think we should make an InternalRunnerContext, let me know.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to