twalthr commented on code in PR #26924:
URL: https://github.com/apache/flink/pull/26924#discussion_r2391415089
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalMLPredictTableFunctionRule.java:
##########
@@ -72,7 +99,119 @@ public boolean matches(RelOptRuleCall call) {
final RelTraitSet providedTraitSet =
rel.getTraitSet().replace(FlinkConventions.STREAM_PHYSICAL());
+
+ // Extract and validate configuration from the 4th operand if present
+ final RexCall rexCall = (RexCall) scan.getCall();
+ final Map<String, String> runtimeConfig = buildRuntimeConfig(rexCall);
+
return new StreamPhysicalMLPredictTableFunction(
Review Comment:
Once we add more built-in PTFs, we might need to support easy extraction of
map literals. But for now this seems ok to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
