ferenc-csaky commented on code in PR #8:
URL:
https://github.com/apache/flink-connector-http/pull/8#discussion_r2578200392
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/sink/HttpDynamicTableSinkFactory.java:
##########
@@ -38,7 +38,7 @@
/** Factory for creating {@link HttpDynamicSink}. */
public class HttpDynamicTableSinkFactory extends AsyncDynamicTableSinkFactory {
- public static final String IDENTIFIER = "http-sink";
+ public static final String IDENTIFIER = "http-apache-sink";
Review Comment:
I don't like `http-apache-sink`. I have no problem with renaming the other
ones, cause the changed names are generic too, but otherwise I'd prefer
renaming it downstream. If it's not possible, then give it some general name
that does not tie it to anything specifically, e.g. `http-async-sink`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
