ferenc-csaky commented on code in PR #8:
URL:
https://github.com/apache/flink-connector-http/pull/8#discussion_r2578204236
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/HttpLookupTableSourceFactory.java:
##########
@@ -141,7 +141,7 @@ protected void
validateHttpLookupSourceOptions(ReadableConfig tableOptions)
@Override
public String factoryIdentifier() {
- return "rest-lookup";
+ return "http";
Review Comment:
Lets add a class level constant `IDENTIFIER` for this as well, that's the
common practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
