tomncooper commented on code in PR #48:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/48#discussion_r2662246647
##########
pom.xml:
##########
@@ -60,9 +60,8 @@ under the License.
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
- <target.java.version>1.8</target.java.version>
- <maven.compiler.source>${target.java.version}</maven.compiler.source>
- <maven.compiler.target>${target.java.version}</maven.compiler.target>
+ <maven.compiler.source>17</maven.compiler.source>
+ <maven.compiler.target>17</maven.compiler.target>
Review Comment:
I set the compiler source and target to match the current Flink 2.0 main
project default which is JDK 17 for both?
```
<source.java.version>11</source.java.version>
<target.java.version>17</target.java.version>
...
<maven.compiler.source>${target.java.version}</maven.compiler.source>
<maven.compiler.target>${target.java.version}</maven.compiler.target>
```
I realise (from @ferenc-csaky's comment above) that this might actually be a
typo/misconfiguration in the main project. I also agree that the profiles make
this all somewhat of a moot point.
So should we just settle on these pom compiler defaults being **both** set
to the lowest _supported_ JDK version, in this case JDK 11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
