davidradl commented on code in PR #48:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/48#discussion_r2662343039
##########
pom.xml:
##########
@@ -60,9 +60,8 @@ under the License.
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
- <target.java.version>1.8</target.java.version>
- <maven.compiler.source>${target.java.version}</maven.compiler.source>
- <maven.compiler.target>${target.java.version}</maven.compiler.target>
+ <maven.compiler.source>17</maven.compiler.source>
+ <maven.compiler.target>17</maven.compiler.target>
Review Comment:
@tomncooper You make a good point. My worry is, in addition to the IDE, this
is inconsistent with Flink maven builds. In a dev environment, `mvn clean
install` for a connector and Flink - would have different targeted jdks (unless
a profile is specified). This means that, without a profile I would need a
different level of JAVA to compile the connectors and Flink locally.
When we get Flink changed (I assume in a future version), then we could
produce another level of this parent connector and match those default levels.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
