fapaul commented on code in PR #215:
URL:
https://github.com/apache/flink-connector-kafka/pull/215#discussion_r2757769660
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaCommittableSerializerTest.java:
##########
@@ -29,7 +27,7 @@
* Tests for serializing and deserialzing {@link KafkaCommittable} with {@link
* KafkaCommittableSerializer}.
*/
-public class KafkaCommittableSerializerTest extends TestLogger {
+public class KafkaCommittableSerializerTest {
Review Comment:
I guess the logger was never used by this class?
##########
flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SmokeKafkaITCase.java:
##########
@@ -28,7 +28,6 @@
import org.apache.flink.connector.testframe.container.TestcontainersSettings;
import org.apache.flink.test.resources.ResourceTestUtils;
import org.apache.flink.test.util.JobSubmission;
-import org.apache.flink.util.TestLoggerExtension;
Review Comment:
Is this a common pattern to load the logger extension via SPI? I am seeing
that the first time :)
Usually for these topics I tend to follow what the main repository uses
##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaDynamicTableFactoryTest.java:
##########
@@ -157,8 +157,6 @@ public class UpsertKafkaDynamicTableFactoryTest extends
TestLogger {
new TestFormatFactory.DecodingFormatMock(
",", true, ChangelogMode.insertOnly(),
Collections.emptyMap());
- @Rule public ExpectedException thrown = ExpectedException.none();
Review Comment:
Is this exception also unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
