Savonitar commented on PR #215: URL: https://github.com/apache/flink-connector-kafka/pull/215#issuecomment-3841975745
Hi @fapaul . Thank you for the review. > The second commit IMO shouldn't be a separate commit at all since it directly touched code again that the previous commit on the PR has introduced. My motivation for separating the commits was to simplify the review process for the migration itself. I wanted reviewers to focus on the core JUnit 4 -> JUnit 5 migration in the first commit without mixing in the SPI refactoring, which could hide potential migration issues. That said, I'm happy to squash them if you think a single commit is clearer. I'll also rename the `[hotfix]` tags - thanks for the clarification on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
