rkhachatryan commented on code in PR #27624:
URL: https://github.com/apache/flink/pull/27624#discussion_r2817104525
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannel.java:
##########
@@ -346,6 +346,11 @@ public long unsynchronizedGetSizeOfQueuedBuffers() {
*/
public void notifyRequiredSegmentId(int subpartitionId, int segmentId)
throws IOException {}
+ /** Whether this input channel has encountered error. */
+ public boolean hasError() {
+ return cause.get() != null;
Review Comment:
I agree, I just wanted to agree on the approach first.
Other approaches are passing `ignoreErrors` to `notifyBufferAvailable` or
ignoring errors coming from it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
