rkhachatryan commented on code in PR #27624:
URL: https://github.com/apache/flink/pull/27624#discussion_r2826888694
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/io/AbstractStreamTaskNetworkInput.java:
##########
@@ -316,8 +322,23 @@ public CompletableFuture<?> getAvailableFuture() {
@Override
public void close() throws IOException {
// release the deserializers . this part should not ever fail
+ Exception err = null;
for (InputChannelInfo channelInfo : new
ArrayList<>(recordDeserializers.keySet())) {
- releaseDeserializer(channelInfo);
+ final boolean hadError =
+
checkpointedInputGate.getChannel(channelInfo.getInputChannelIdx()).hasError();
+ try {
+ releaseDeserializer(channelInfo);
+ } catch (Exception e) {
+ if (hadError) {
+ LOG.warn(
+ "Ignoring deserializer release failure - the
channel has encountered an error before");
+ } else {
+ err = e;
Review Comment:
Good point, I'll use `firstOrSuppressed`.
Covering this with unti tests I think is overkill though, this is not a
critical information IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
