1996fanrui commented on code in PR #27624:
URL: https://github.com/apache/flink/pull/27624#discussion_r2828119194
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/io/AbstractStreamTaskNetworkInput.java:
##########
@@ -318,10 +324,17 @@ public void close() throws IOException {
// release the deserializers . this part should not ever fail
Exception err = null;
for (InputChannelInfo channelInfo : new
ArrayList<>(recordDeserializers.keySet())) {
+ final boolean hadError =
+
checkpointedInputGate.getChannel(channelInfo.getInputChannelIdx()).hasError();
Review Comment:
I share the same concern you mentioned.
The current `catch (Exception e) + if (hadError)` would swallow *all*
exceptions from `releaseDeserializer`, not just the channel error. If e.g.
`globalPool.recycleUnpooledMemorySegments` fails while `hadError=true`, that
failure is silently lost.
And it is dangerous if introducing new exception in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
