xintongsong commented on code in PR #556:
URL: https://github.com/apache/flink-agents/pull/556#discussion_r2889286254
##########
e2e-test/flink-agents-end-to-end-tests-integration/src/test/java/org/apache/flink/agents/integration/test/ChatModelIntegrationAgent.java:
##########
@@ -84,6 +84,11 @@ public static ResourceDescriptor chatModelConnection() {
return
ResourceDescriptor.Builder.newBuilder(ResourceName.ChatModel.OPENAI_CONNECTION)
.addInitialArgument("api_key", apiKey)
.build();
+ } else if (provider.equals("OPENAI_RESPONSE")) {
Review Comment:
```suggestion
} else if (provider.equals("OPENAI_RESPONSES")) {
```
##########
api/src/main/java/org/apache/flink/agents/api/resource/ResourceName.java:
##########
@@ -71,6 +71,12 @@ public static final class ChatModel {
public static final String OPENAI_SETUP =
"org.apache.flink.agents.integrations.chatmodels.openai.OpenAIChatModelSetup";
+ // OpenAI Responses API
+ public static final String OPENAI_RESPONSE_CONNECTION =
+
"org.apache.flink.agents.integrations.chatmodels.openai.OpenAIResponseModelConnection";
+ public static final String OPENAI_RESPONSE_SETUP =
+
"org.apache.flink.agents.integrations.chatmodels.openai.OpenAIResponseModelSetup";
+
Review Comment:
1. According to the
[documents](https://developers.openai.com/api/reference/responses/overview),
the formal name of the API is "Responses API". Let's make it consistent and use
RESPONSES (rather than RESPONSE) for the constants and class names.
2. I'd suggest to also change `OPENAI_CONNECTION` to
`OPENAI_COMPLETIONS_CONNECTION`, as well as the class names, to avoid confusion.
3. There are some string constants for referencing java integrations from
python codes in `resource.py`, which should also be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
