addu390 commented on code in PR #556:
URL: https://github.com/apache/flink-agents/pull/556#discussion_r2890317869
##########
api/src/main/java/org/apache/flink/agents/api/resource/ResourceName.java:
##########
@@ -71,6 +71,12 @@ public static final class ChatModel {
public static final String OPENAI_SETUP =
"org.apache.flink.agents.integrations.chatmodels.openai.OpenAIChatModelSetup";
+ // OpenAI Responses API
+ public static final String OPENAI_RESPONSE_CONNECTION =
+
"org.apache.flink.agents.integrations.chatmodels.openai.OpenAIResponseModelConnection";
+ public static final String OPENAI_RESPONSE_SETUP =
+
"org.apache.flink.agents.integrations.chatmodels.openai.OpenAIResponseModelSetup";
+
Review Comment:
Missed those in `resource.py`, I made the changes to fix naming across the
code-base.
Should we also rename `OpenAIChatModelConnection` to
`OpenAICompletionsConnection`, `OpenAIChatModelSetup` to
`OpenAICompletionsSetup` for consistency in naming?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
