Zakelly commented on code in PR #27662:
URL: https://github.com/apache/flink/pull/27662#discussion_r3004882741
##########
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/util/MetricUtils.java:
##########
@@ -351,7 +352,7 @@ static void instantiateFileDescriptorMetrics(MetricGroup
metrics) {
metrics.<Long, Gauge<Long>>gauge("Max",
unixMXBean::getMaxFileDescriptorCount);
metrics.<Long, Gauge<Long>>gauge("Open",
unixMXBean::getOpenFileDescriptorCount);
- } else {
+ } else if (!OperatingSystem.isWindows()) {
Review Comment:
It is reasonable to output a warning when initialization fails. Users need
to be informed that certain features have been disabled.
I'd suggest refining the warning messages to avoid confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
