piotrp commented on code in PR #27662:
URL: https://github.com/apache/flink/pull/27662#discussion_r3005130934
##########
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/util/MetricUtils.java:
##########
@@ -351,7 +352,7 @@ static void instantiateFileDescriptorMetrics(MetricGroup
metrics) {
metrics.<Long, Gauge<Long>>gauge("Max",
unixMXBean::getMaxFileDescriptorCount);
metrics.<Long, Gauge<Long>>gauge("Open",
unixMXBean::getOpenFileDescriptorCount);
- } else {
+ } else if (!OperatingSystem.isWindows()) {
Review Comment:
Ok, added. This needed some more code because MiniCluster calls this method
twice - once as a JobMaster, once as a TaskManager, and a single log line is
enough.
I'm not convinced, as you want to inform Windows developers that a
Unix-specific metric, present only in `UnixOperatingSystemMXBean`, is not
available to them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
