featzhang commented on code in PR #32:
URL:
https://github.com/apache/flink-connector-http/pull/32#discussion_r3026819572
##########
docs/content.zh/docs/connectors/datastream/http.md:
##########
@@ -52,7 +52,7 @@ These options are specified on the builder using the
setProperty method.
| Option | Required |
Description/Value
|
|---------------------------------------------------------|----------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| connector | required | Specify
what connector to use. For HTTP Sink it should be set to _'http-sink'_.
|
+| connector | required | Specify
what connector to use. For HTTP Sink it should be set to _'http-async-sink'_.
|
Review Comment:
Thanks for the question, @davidradl.
This is a documentation fix I noticed while working on this PR. The actual
connector identifier registered in `HttpDynamicTableSinkFactory` is
http-async-sink, not http-sink. The original doc had an incorrect value that
could confuse users when defining their DDL.
https://github.com/apache/flink-connector-http/blob/21b3d9a124fa8294f85c1ae0935ea9fa8bae62f7/flink-connector-http/src/main/java/org/apache/flink/connector/http/table/sink/HttpDynamicTableSinkFactory.java#L41
I included it in this PR since it's a small doc correction, but I'm happy to
split it into a separate commit or even a separate PR if you prefer to keep
things more focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
