featzhang commented on PR #32:
URL:
https://github.com/apache/flink-connector-http/pull/32#issuecomment-4293175745
@davidradl Thank you for the excellent feedback about documenting the
recommended approach and clarifying precedence.
I've updated the documentation in commit a0feecc to address your concerns:
**Changes made:**
1. **Emphasized recommended approach**: Changed from a simple "Note" to a
prominent "Recommended Approach" callout that clearly states this is the
**recommended way** to configure headers
2. **Listed concrete benefits**:
- Automatic validation by Flink's table option validator
- IDE autocomplete support
- Better documentation and discoverability
- Consistent with other Flink connector configuration patterns
3. **Clarified precedence**: Added explicit statements that "All headers
configured via the `http.source.lookup.header.*` prefix are processed
identically — there is no precedence or conflict resolution." This makes it
clear users don't need to worry about header conflicts.
4. **Improved structure**: Reorganized the sections to present the
recommendation first, followed by usage examples
5. **Applied to both source and sink**: Made consistent changes to both the
lookup source headers section and the sink headers section
The documentation now clearly guides users toward the ConfigOption approach
while explaining why it's beneficial, addressing your concern about
"recommended ways of configuring."
Regarding OIDC for sinks (your earlier comment): That's a great future
enhancement idea! For now, users can manually specify Bearer tokens via
`http.sink.header.Authorization`, but automatic OIDC token management like we
have for lookup joins would be a valuable addition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
