Samrat002 commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3055275602
########## flink-connector-redis-streams/src/main/java/org/apache/flink/connector/redis/streams/source/split/RedisStreamsSourceSplit.java: ########## @@ -0,0 +1,101 @@ +/* Review Comment: This is an intentional v1 design decision. In the current model, parallelism = number of distinct stream keys. This preserves total ordering within each stream, which is critical for many use cases (event sourcing, CDC, ordered processing). Adding parallelismPerStream would mean multiple consumers reading the same stream, which breaks Redis Streams' ordering guarantee. Each consumer gets an arbitrary subset. The Kafka connector follows the same model: 1 split = 1 partition, and intra-partition parallelism is not supported because it breaks ordering. I agree this is worth supporting as an opt-in feature in a follow-up PR where users explicitly accept the ordering trade-off. For v1, keeping the simpler model that preserves correctness. WDUT ? i will add a jira for the further enhancement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
