Poorvankbhatia commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3008005760
########## flink-connector-redis-streams/src/main/java/org/apache/flink/connector/redis/streams/source/split/RedisStreamsSourceSplit.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.redis.streams.source.split; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.api.connector.source.SourceSplit; + +import java.io.Serializable; +import java.util.Objects; + +/** + * A split representing a Redis Stream key. + * + * <p>Each split corresponds to one Redis Stream key and tracks the last read entry ID for + * checkpointing purposes. + */ +@PublicEvolving +public class RedisStreamsSourceSplit implements SourceSplit, Serializable { + + private static final long serialVersionUID = 1L; + + private final String streamKey; + private final String lastReadEntryId; + + /** + * Creates a new split for a Redis Stream. + * + * @param streamKey The Redis Stream key + * @param lastReadEntryId The ID of the last entry read from this stream (null if starting + * fresh) + */ + public RedisStreamsSourceSplit(String streamKey, String lastReadEntryId) { + this.streamKey = Objects.requireNonNull(streamKey, "Stream key cannot be null"); Review Comment: NIT: Use `Preconditions.checkNotNull(streamKey, "streamKey")` from org.apache.flink.util.Preconditions instead of `Objects.requireNonNull.` ########## flink-connector-redis-streams/src/main/java/org/apache/flink/connector/redis/streams/source/split/RedisStreamsSourceSplit.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.redis.streams.source.split; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.api.connector.source.SourceSplit; + +import java.io.Serializable; +import java.util.Objects; + +/** + * A split representing a Redis Stream key. + * + * <p>Each split corresponds to one Redis Stream key and tracks the last read entry ID for + * checkpointing purposes. + */ +@PublicEvolving +public class RedisStreamsSourceSplit implements SourceSplit, Serializable { + + private static final long serialVersionUID = 1L; + + private final String streamKey; + private final String lastReadEntryId; + + /** + * Creates a new split for a Redis Stream. + * + * @param streamKey The Redis Stream key + * @param lastReadEntryId The ID of the last entry read from this stream (null if starting + * fresh) + */ + public RedisStreamsSourceSplit(String streamKey, String lastReadEntryId) { + this.streamKey = Objects.requireNonNull(streamKey, "Stream key cannot be null"); + this.lastReadEntryId = lastReadEntryId; + } + + @Override + public String splitId() { + return streamKey; + } + + public String getStreamKey() { + return streamKey; + } + + public String getLastReadEntryId() { + return lastReadEntryId; + } + + /** + * Creates a new split with an updated last read entry ID. + * + * @param newLastReadEntryId The new last read entry ID + * @return A new split instance with the updated entry ID + */ + public RedisStreamsSourceSplit withLastReadEntryId(String newLastReadEntryId) { + return new RedisStreamsSourceSplit(streamKey, newLastReadEntryId); + } + + @Override + public boolean equals(Object o) { Review Comment: Again equals should not have `lastReadEntryId` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
