raminqaf commented on code in PR #27901: URL: https://github.com/apache/flink/pull/27901#discussion_r3063822431
########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinition.java: ########## Review Comment: I tried this but, implementing `ChangelogFunction` on `BuiltInFunctionDefinition` can't give us dynamic changelog mode based on (input) arguments, because `ChangelogContext` only provides input changelog modes and downstream requirements and not the function's arguments like `op_mapping`. We need the `CallContext` to inspect the inputs (i.e., from `op_mapping`), which is what the resolver provides. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
