raminqaf commented on code in PR #27901:
URL: https://github.com/apache/flink/pull/27901#discussion_r3063826920
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkChangelogModeInferenceProgram.scala:
##########
@@ -1705,18 +1705,27 @@ class FlinkChangelogModeInferenceProgram extends
FlinkOptimizeProgram[StreamOpti
defaultTraitSet: T): T = {
val call = process.getCall
val definition = ShortcutUtils.unwrapFunctionDefinition(call)
- val changelogFunctionOpt: Option[ChangelogFunction] = definition match {
- case cf: ChangelogFunction => Some(cf)
- case builtIn: BuiltInFunctionDefinition if
builtIn.getChangelogFunction.isPresent =>
- Some(builtIn.getChangelogFunction.get())
- case _ => None
- }
- changelogFunctionOpt match {
- case Some(changelogFunction) =>
- val inputChangelogModes = children.map(toChangelogMode(_, None, None))
+ val inputChangelogModes = children.map(toChangelogMode(_, None, None))
+ val changelogModeOpt: Option[ChangelogMode] = definition match {
+ // User-defined PTFs that implement ChangelogFunction
+ case cf: ChangelogFunction =>
Review Comment:
See comment:
https://github.com/apache/flink/pull/27901#discussion_r3063822431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
