snuyanzin commented on code in PR #27907:
URL: https://github.com/apache/flink/pull/27907#discussion_r3071040782
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConvertUtils.java:
##########
@@ -87,7 +87,7 @@ static CatalogView toCatalogView(
context.getSqlValidator().getNamespace(validateQuery);
validateDuplicatedColumnNames(validateQuery, viewFields,
validatedNamespace);
- String expandedQuery = context.toQuotedSqlString(validateQuery);
+ String expandedQuery = context.expandSqlIdentifiers(originalQuery);
Review Comment:
>the LATERAL issue: expandSqlIdentifiers was being used until the Calcite
version (problem resolved) was updated
this is not entirely true
`LATERAL` was fixed in https://issues.apache.org/jira/browse/CALCITE-7217
and https://issues.apache.org/jira/browse/CALCITE-7312 which are 1.41.0 and
1.42.0 (not even released yet) and Flink master depends on 1.36.0
Calcite upgrade task is not an easy one because of lots of customizations
So we just port fixes from Calcite and remove such fixes when upgrade to
certain version
for that reason you can find calcite classes in Flink repo e.g. here
https://github.com/apache/flink/tree/master/flink-table/flink-table-planner/src/main/java/org/apache/calcite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
