raminqaf commented on code in PR #27901:
URL: https://github.com/apache/flink/pull/27901#discussion_r3071229304
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinition.java:
##########
@@ -72,6 +74,9 @@ public final class BuiltInFunctionDefinition implements
SpecializedFunction {
private final SqlCallSyntax sqlCallSyntax;
+ private final @Nullable Function<ChangelogFunction.ChangelogContext,
ChangelogMode>
Review Comment:
addressed
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkChangelogModeInferenceProgram.scala:
##########
@@ -1705,17 +1708,21 @@ class FlinkChangelogModeInferenceProgram extends
FlinkOptimizeProgram[StreamOpti
defaultTraitSet: T): T = {
val call = process.getCall
val definition = ShortcutUtils.unwrapFunctionDefinition(call)
- definition match {
- case changelogFunction: ChangelogFunction =>
- val inputChangelogModes = children.map(toChangelogMode(_, None, None))
+ val inputChangelogModes = children.map(toChangelogMode(_, None, None))
Review Comment:
addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
