gustavodemorais commented on code in PR #27901:
URL: https://github.com/apache/flink/pull/27901#discussion_r3087235480


##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinition.java:
##########
@@ -52,7 +54,7 @@
  * <p>Equality is defined by reference equality.
  */
 @Internal
-public final class BuiltInFunctionDefinition implements SpecializedFunction {
+public final class BuiltInFunctionDefinition implements SpecializedFunction, 
ChangelogFunction {

Review Comment:
   @twalthr, just to check if we are all on the same page, you mean something 
like
   
   1. Remove ChangelogFunction from BuiltInFunctionDefinition
   2. Make FromChangelog implements ChangelogFunction
   3. Specialize the function in FlinkChangelogModeInferenceProgram, which then 
makes it match ChangelogFunction



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to