twalthr commented on code in PR #27901:
URL: https://github.com/apache/flink/pull/27901#discussion_r3087646254
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinition.java:
##########
@@ -52,7 +54,7 @@
* <p>Equality is defined by reference equality.
*/
@Internal
-public final class BuiltInFunctionDefinition implements SpecializedFunction {
+public final class BuiltInFunctionDefinition implements SpecializedFunction,
ChangelogFunction {
Review Comment:
After thinking about this comment again, I'm fine with the current strategy.
Let's keep this in common. I would just slightly adjust the interfaces:
```
BuiltInFunctionDefinition.changelogMode(ChangelogModeStrategy)
```
With ChangelogModeStrategy, we follow a similar design as for TypeStrategy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
