gustavodemorais commented on code in PR #27886:
URL: https://github.com/apache/flink/pull/27886#discussion_r3122968866
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/SystemTypeInference.java:
##########
@@ -182,6 +182,32 @@ private static void checkReservedArgs(List<StaticArgument>
staticArgs) {
}
}
+ static TraitContext buildTraitContext(
+ @Nullable final TableSemantics semantics,
+ final CallContext callContext,
+ final List<StaticArgument> staticArgs) {
+ return new TraitContext() {
Review Comment:
Yes, we need the CallContext to resolve the arguments and there no obvious
single place to resolve this once so that we don't have multiple places. At
logical time, for example when we create TypeInputStrategy, we only have the
Logical Operator instance but not the CallContext yet - a logical operator can
be reused multiple times throughout multiple calls inside a single SQL command.
But I agree with you: I don't like this and that's what i'm doing now, trying
to find a better place so we do it only once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
