gustavodemorais commented on code in PR #27886:
URL: https://github.com/apache/flink/pull/27886#discussion_r3125205773
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/StaticArgument.java:
##########
@@ -196,6 +211,91 @@ public boolean is(StaticArgumentTrait trait) {
return traits.contains(trait);
}
+ /**
+ * Context-aware trait check. Evaluates conditional trait rules against
the given context to
+ * determine the effective traits.
+ */
+ public boolean is(StaticArgumentTrait trait, TraitContext ctx) {
+ return resolveTraits(ctx).contains(trait);
+ }
+
+ /**
+ * Returns a new {@link StaticArgument} with an additional conditional
trait rule. The trait is
+ * added to the effective trait set when the condition evaluates to {@code
true} at planning
+ * time. Only non-root traits (subtraits of TABLE, SCALAR, or MODEL) are
allowed.
+ *
+ * <p>Multiple conditions for the same trait use OR semantics: the trait
is activated if any of
+ * its conditions is met.
+ *
+ * <p>Example:
+ *
+ * <pre>{@code
+ * StaticArgument.table("input", Row.class, false, EnumSet.of(TABLE,
SUPPORT_UPDATES))
+ * .withConditionalTrait(SET_SEMANTIC_TABLE, hasPartitionBy());
+ * }</pre>
+ */
+ public StaticArgument withConditionalTrait(
+ final StaticArgumentTrait trait, final TraitCondition condition) {
+ if (trait == StaticArgumentTrait.SCALAR
+ || trait == StaticArgumentTrait.TABLE
+ || trait == StaticArgumentTrait.MODEL) {
+ throw new IllegalArgumentException(
+ "Root traits (SCALAR, TABLE, MODEL) cannot be
conditional.");
+ }
+ final List<ConditionalTrait> accumulated = new
ArrayList<>(this.conditionalTraits);
+ accumulated.add(new ConditionalTrait(condition, trait));
+ return new StaticArgument(name, dataType, conversionClass, isOptional,
traits, accumulated);
+ }
+
+ /** Whether this argument has conditional trait rules. */
+ public boolean hasConditionalTraits() {
+ return !conditionalTraits.isEmpty();
+ }
+
+ /** Whether any conditional trait rule may add the given trait. */
+ public boolean hasConditionalTrait(final StaticArgumentTrait trait) {
+ return conditionalTraits.stream().anyMatch(c -> c.trait == trait);
+ }
+
+ /**
+ * Returns a new {@link StaticArgument} with conditional traits resolved
against the given
+ * context. The returned argument has the effective traits baked in and no
conditional rules.
+ */
+ public StaticArgument applyConditionalTraits(final TraitContext ctx) {
+ if (conditionalTraits.isEmpty()) {
+ return this;
+ }
+ return new StaticArgument(name, dataType, conversionClass, isOptional,
resolveTraits(ctx));
+ }
+
+ /**
+ * Resolves effective traits by evaluating conditional rules against the
context. Returns the
+ * base traits combined with any conditional traits whose conditions are
met.
+ */
+ public EnumSet<StaticArgumentTrait> resolveTraits(final TraitContext ctx) {
+ if (conditionalTraits.isEmpty()) {
+ return traits;
+ }
+ final EnumSet<StaticArgumentTrait> resolved = EnumSet.copyOf(traits);
+ for (final ConditionalTrait conditionalTrait : conditionalTraits) {
+ if (conditionalTrait.condition.test(ctx)) {
+ removeMutuallyExclusiveTraits(resolved,
conditionalTrait.trait);
+ resolved.add(conditionalTrait.trait);
+ }
+ }
+ return resolved;
+ }
+
+ /** ROW and SET semantics are mutually exclusive - adding one removes the
other. */
+ private static void removeMutuallyExclusiveTraits(
+ final EnumSet<StaticArgumentTrait> traits, final
StaticArgumentTrait adding) {
+ if (adding == StaticArgumentTrait.SET_SEMANTIC_TABLE) {
Review Comment:
Done
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/StaticArgument.java:
##########
@@ -196,6 +211,91 @@ public boolean is(StaticArgumentTrait trait) {
return traits.contains(trait);
}
+ /**
+ * Context-aware trait check. Evaluates conditional trait rules against
the given context to
+ * determine the effective traits.
+ */
+ public boolean is(StaticArgumentTrait trait, TraitContext ctx) {
+ return resolveTraits(ctx).contains(trait);
+ }
+
+ /**
+ * Returns a new {@link StaticArgument} with an additional conditional
trait rule. The trait is
+ * added to the effective trait set when the condition evaluates to {@code
true} at planning
+ * time. Only non-root traits (subtraits of TABLE, SCALAR, or MODEL) are
allowed.
+ *
+ * <p>Multiple conditions for the same trait use OR semantics: the trait
is activated if any of
+ * its conditions is met.
+ *
+ * <p>Example:
+ *
+ * <pre>{@code
+ * StaticArgument.table("input", Row.class, false, EnumSet.of(TABLE,
SUPPORT_UPDATES))
+ * .withConditionalTrait(SET_SEMANTIC_TABLE, hasPartitionBy());
+ * }</pre>
+ */
+ public StaticArgument withConditionalTrait(
+ final StaticArgumentTrait trait, final TraitCondition condition) {
+ if (trait == StaticArgumentTrait.SCALAR
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
