raminqaf commented on code in PR #27994:
URL: https://github.com/apache/flink/pull/27994#discussion_r3129230574
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/FromChangelogTypeStrategy.java:
##########
@@ -47,6 +48,40 @@ public final class FromChangelogTypeStrategy {
private static final Set<String> VALID_ROW_KIND_NAMES =
Set.of("INSERT", "UPDATE_BEFORE", "UPDATE_AFTER", "DELETE");
+ private static final String UPDATE_BEFORE = RowKind.UPDATE_BEFORE.name();
+
+ private static final String UPDATE_AFTER = RowKind.UPDATE_AFTER.name();
+
+ /**
+ * Controls behavior when {@code FROM_CHANGELOG} encounters an operation
code in the input that
+ * is not present in the {@code op_mapping}. Mode names are case-sensitive
— the value must be
+ * spelled in upper case.
+ *
+ * <ul>
+ * <li>{@code FAIL} — throw an exception when an unmapped operation code
is encountered
+ * (default, strict mode)
+ * <li>{@code SKIP} — silently drop the row
+ * </ul>
+ */
+ public enum InvalidOpHandlingMode {
Review Comment:
Moved it in its own top-level enum
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/FromChangelogTypeStrategy.java:
##########
@@ -47,6 +48,40 @@ public final class FromChangelogTypeStrategy {
private static final Set<String> VALID_ROW_KIND_NAMES =
Set.of("INSERT", "UPDATE_BEFORE", "UPDATE_AFTER", "DELETE");
+ private static final String UPDATE_BEFORE = RowKind.UPDATE_BEFORE.name();
+
+ private static final String UPDATE_AFTER = RowKind.UPDATE_AFTER.name();
+
+ /**
+ * Controls behavior when {@code FROM_CHANGELOG} encounters an operation
code in the input that
+ * is not present in the {@code op_mapping}. Mode names are case-sensitive
— the value must be
+ * spelled in upper case.
+ *
+ * <ul>
+ * <li>{@code FAIL} — throw an exception when an unmapped operation code
is encountered
+ * (default, strict mode)
+ * <li>{@code SKIP} — silently drop the row
+ * </ul>
+ */
+ public enum InvalidOpHandlingMode {
Review Comment:
Moved it to its own top-level enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
