raminqaf commented on code in PR #27994:
URL: https://github.com/apache/flink/pull/27994#discussion_r3129791780
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/FromChangelogSemanticTests.java:
##########
@@ -42,6 +42,8 @@ public List<TableTestProgram> programs() {
FromChangelogTestPrograms.DEFAULT_OP_MAPPING,
FromChangelogTestPrograms.CUSTOM_OP_MAPPING,
FromChangelogTestPrograms.CUSTOM_OP_NAME,
+ FromChangelogTestPrograms.SKIP_INVALID_OP_HANDLING,
Review Comment:
I would push back on this one. Since the test already contains the word
`SKIP` and the rest defines what type of error is being handled. We have
another test `SKIP_NULL_OP_CODE` which is another case of the error handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
