[ 
https://issues.apache.org/jira/browse/FLINK-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833952#comment-15833952
 ] 

ASF GitHub Bot commented on FLINK-5508:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3157#discussion_r97255788
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java 
---
    @@ -376,15 +376,19 @@ public static ZooKeeperCheckpointIDCounter 
createCheckpointIDCounter(
                }
        }
     
    -   private static String generateZookeeperPath(String root, String 
namespace) {
    +   public static String generateZookeeperPath(String root, String 
namespace) {
                if (!namespace.startsWith("/")) {
    -                   namespace = "/" + namespace;
    +                   namespace = '/' + namespace;
                }
     
                if (namespace.endsWith("/")) {
                        namespace = namespace.substring(0, namespace.length() - 
1);
                }
     
    +           if (root.endsWith("/")) {
    --- End diff --
    
    Nice catch ..


> Remove Mesos dynamic class loading
> ----------------------------------
>
>                 Key: FLINK-5508
>                 URL: https://issues.apache.org/jira/browse/FLINK-5508
>             Project: Flink
>          Issue Type: Improvement
>          Components: Mesos
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.2.0, 1.3.0
>
>
> Mesos uses dynamic class loading in order to load the 
> {{ZooKeeperStateHandleStore}} and the {{CuratorFramework}} class. This can be 
> replaced by a compile time dependency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to