[
https://issues.apache.org/jira/browse/FLINK-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833949#comment-15833949
]
ASF GitHub Bot commented on FLINK-5508:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3157#discussion_r97256203
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperVersionedValue.java
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.zookeeper;
+
+import org.apache.curator.framework.recipes.shared.VersionedValue;
+import org.apache.flink.util.Preconditions;
+
+/**
+ * Wrapper class for a {@link VersionedValue} so that we don't expose a
curator dependency in our
+ * internal APIs. Such an exposure is problematic due to the relocation of
curator.
+ */
+public class ZooKeeperVersionedValue<T> {
+
+ private final VersionedValue<T> versionedValue;
+
+ public ZooKeeperVersionedValue(VersionedValue<T> versionedValue) {
+ this.versionedValue =
Preconditions.checkNotNull(versionedValue);
+ }
+
+ VersionedValue<T> getVersionedValue() {
--- End diff --
nitpick: I would place the public methods before any other package-private
/ private access methods.
> Remove Mesos dynamic class loading
> ----------------------------------
>
> Key: FLINK-5508
> URL: https://issues.apache.org/jira/browse/FLINK-5508
> Project: Flink
> Issue Type: Improvement
> Components: Mesos
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Fix For: 1.2.0, 1.3.0
>
>
> Mesos uses dynamic class loading in order to load the
> {{ZooKeeperStateHandleStore}} and the {{CuratorFramework}} class. This can be
> replaced by a compile time dependency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
