Poorvankbhatia commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3162328384
########## flink-connector-redis-streams/src/main/java/org/apache/flink/connector/redis/streams/source/config/StartupMode.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.redis.streams.source.config; + +import org.apache.flink.annotation.PublicEvolving; + +/** + * Startup position used only when the consumer group is created (BUSYGROUP otherwise resumes from + * the group's existing position). {@code EARLIEST} = {@code 0-0}; {@code LATEST} = {@code $}. + */ +@PublicEvolving Review Comment: Redis's XGROUP CREATE actually accepts ANY entry ID as the starting position, not just 0-0 or $. So you could create a group positioned at, say, 1700000000000-0 to start from a specific timestamp. Right now, this enum only exposes the two extremes. Anyone who wants to "start from the entry ID I checkpointed externally" has no way to do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
