Poorvankbhatia commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3162478923
########## flink-connector-redis-streams/src/main/java/org/apache/flink/connector/redis/streams/source/config/RedisStreamsSourceConfig.java: ########## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.redis.streams.source.config; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.util.Preconditions; + +import java.io.Serializable; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.UUID; + +/** + * Configuration for the Redis Streams Source. + * + * <p>Set {@link Builder#setHost} + {@link Builder#setPort} for standalone mode, or {@link + * Builder#setClusterNodes} for cluster mode (host/port are ignored when cluster mode is active). + * + * <p>The effective per-subtask consumer name is {@code <consumerName>-<subtaskIndex>}. Pinning + * {@code consumerName} explicitly is required to preserve PEL recovery across parallelism changes + * or redeploys; the default UUID-suffixed name changes on each {@code Builder.build()}. + */ +@PublicEvolving +public class RedisStreamsSourceConfig implements Serializable { + + private static final long serialVersionUID = 2L; + + public static final String DEFAULT_CONSUMER_GROUP = "flink-consumer-group"; Review Comment: I am not sure I agree with the defaults here. See, if two unrelated Flink jobs both use this connector against the same Redis without setting consumerGroup, they share the same Redis consumer group. Will they fight over messages — each entry goes to ONE of the two jobs (random). Silent cross-job interference. I think the model that this PR approaches, where each job owns its consumption, **the consumer group should probably be required, not defaulted**. Or the default should include the job ID / streamKeys hash. Let me know if that makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
